You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using useContext outside of a provider can cause unforeseen and cryptic errors. This PR adds a warning (in dev) when the result of useContext is falsy.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thanks for the PR. I’m going to close this as stale for Solid 2.
The underlying issue is real: reading a default-less context outside its Provider can lead to confusing errors later. In Solid 2, though, default-less contexts now throw immediately when read without a Provider, and useContext(createContext<T>()) is typed as T, so this is handled more directly.
I also don’t think this exact warning is safe to add. Context values can legitimately be falsy — false, 0, "", or even null depending on the context type — so warning based on a falsy result would produce false positives.
For the 1.x line, I think the better fix is a type-level one: distinguish default-less contexts so providers don’t accidentally accept undefined unless the context type explicitly includes it. That addresses the common mistake without warning on valid context values. As outlined as my response to #1958.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Using
useContextoutside of a provider can cause unforeseen and cryptic errors. This PR adds a warning (in dev) when the result ofuseContextis falsy.See https://discord.com/channels/722131463138705510/1358899310116213008
Typescript does protect against using an undefined context somewhat, but I thought a warning could be nice, especially for new users.
How did you test this change?
Created a project and consumed a context without being in its provider:

Warning is printed to the console.
After the project has been built, the warning is not logged.